This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Conversation
product-auto-label
Bot
added
the
api: spanner
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
cc @rayudu3745 |
asthamohta
reviewed
Nov 5, 2024
| session.install("opentelemetry-api==1.27.0") | ||
| session.install("opentelemetry-sdk==1.27.0") | ||
| session.install("opentelemetry-instrumentation==0.48b0") | ||
| session.run("python", "create_test_database.py") |
Contributor
There was a problem hiding this comment.
If my understanding is correct, we cleanup the databases only when a new system test is run, right? Do we want to keep the database around to check for errors? Shouldn't we do a cleanup post the system tests being run as well?
Contributor
Author
There was a problem hiding this comment.
Correct, we were only cleaning up during the following run (and then only databases older than 4 hours). I've added a cleanup job that is executed after the system tests have executed.
asthamohta
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.